Draft
Conversation
…Q, including new types and structures for feedback reports, and integrate feedback decision logic into the session management.
…feedback reporting with new structures for track-level quality and connection stats.
… clients to send upload tracks and servers to subscribe, enhancing media quality reporting and network statistics collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the complete delivery feedback mechanism defined in draft-moq-delivery-feedback-00 on top of xquic's existing MoQ draft-14 protocol stack. This covers receiver-side delivery status tracking, Feedback Report encoding/decoding, sender-side CC decision-making, and cross-layer control integration at the QUIC CC layer. All logic is built directly as extensions to the moq_transport real protocol stack, reusing the existing session/track/message framework.
Architecture
Changes by Layer
1. Transport / CC Layer Extensions
include/xquic/xquic.hon_recv_timestampandx_layer_app_eventcallbacks to CC interface; addedxqc_conn_signal_x_layer_app_event()public APIinclude/xquic/xquic_typedef.hXQC_APP_EVENT_PACING_GAIN_UPDATED, etc.) and payload structs (xqc_pacing_gain_update_t, etc.); all payloads carryexpire_timeinclude/xqc_types.hxqc_crosslayer_event_tas the unified event interface for the crosslayer gatewaysrc/transport/xqc_conn.cxqc_conn_signal_x_layer_app_event()to dispatch cross-layer events to the CC algorithmsrc/transport/xqc_frame.csrc/transport/xqc_send_ctl.c/.hsrc/congestion_control/xqc_bbr.c/.hon_recv_timestampcallback for OWD recordingsrc/cc/xqc_crosslayer.c/.h2. QUIC Receive Timestamps
src/recv_ts/xqc_recv_ts.c/.hinclude/xquic/xqc_configure.h3. MoQ Feedback Report Codec
include/moq/xqc_moq_fb_report.hxqc_moq_fb_report_t,xqc_moq_fb_object_row_t,xqc_moq_fb_summary_stats_t,xqc_moq_fb_optional_metric_t, strictly aligned with draft Section 5 formatmoq/moq_transport/xqc_moq_fb_report.csrc/common/xqc_varint.c/.h4. Receiver: Delivery Tracking + Report Generation
moq/moq_transport/xqc_moq_feedback_tracker.c/.hmoq/moq_transport/xqc_moq_fb_report_gen.c/.hmoq/moq_transport/xqc_moq_message_handler.cfb_report_gen_on_media_object_received()to update tracker upon receiving a media Object5. Sender: Feedback Consumption + CC Decision
moq/moq_transport/xqc_moq_feedback_track.c/.hmoq/moq_transport/xqc_moq_feedback_decision.c/.h6. Session / Track Extensions
include/moq/xqc_moq.hon_delivery_feedback/on_feedback_decisioncallbacksmoq/moq_transport/xqc_moq_session.c/.hDELIVERY_FEEDBACKparameter (0xA2, bitmap 0x07), feedback state managementmoq/moq_transport/xqc_moq_track.c/.hfeedback_trackerpointer andtarget_latency_usfieldmoq/CMakeLists.txt7. Demo + E2E Tests
moq/demo/xqc_moq_feedback_client.cmoq/demo/xqc_moq_feedback_server.cscripts/moq_scripts/moq_feedback_test.shE2E Test Cases (18/18 passed)
Feedback Control API (3 Levels)
set_feedback_decision_config()to tune thresholdson_feedback_decisionfor fully custom policy; return XQC_OK = decision made (including explicit NONE no-op); return non-OK = fall back to auto