Skip to content

Comments

Show AlbumArtist in the fileinfo pane#48

Merged
alicebob merged 2 commits intomasterfrom
albuma
Feb 14, 2018
Merged

Show AlbumArtist in the fileinfo pane#48
alicebob merged 2 commits intomasterfrom
albuma

Conversation

@alicebob
Copy link
Owner

Also drop a redundant datatype. See individual commits.

For now it's only displayed (in the fileinfo pane (that's the last pane)).
@alicebob alicebob requested a review from robx February 14, 2018 16:19
]


float : Decode.Decoder Float
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh since when do we have this? seems to be due to go-edn/edn#18?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. It's the JSON->EDN commit: caa285a#diff-f3f2ba0c9505d433e7d7603a0c7e999eR137

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh you'd think I'd remember putting in a work-around like that...

@alicebob alicebob merged commit a77ee6e into master Feb 14, 2018
@alicebob alicebob deleted the albuma branch February 14, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants