MI-250-nx-cdk-generators #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kai-nguyen-aligent
requested review from
TheOrangePuff,
Zigr1,
ryanrixxh and
toddhainsworth
kai-nguyen-aligent
changed the title
aligent-phil
requested changes
Dec 10, 2025
aligent-phil
left a comment
aligent-phil
left a comment
There was a problem hiding this comment.
Just one minor thing to correct. I'm not an nx specialist but I can't see anything egregious in the code that stands out
| export interface PresetGeneratorSchema { | ||
| name: string; | ||
| nodeVersion: string; | ||
| // FIXME: Add this into schema.json once we move to our own cli tool |
There was a problem hiding this comment.
Is there a ticket associated with this task?
Co-authored-by: aligent-phil <85087316+aligent-phil@users.noreply.github.com>
…250-nx-cdk-generators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback