Merged
Conversation
For both gifs and single images
…nder into vector-bugfix
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
|
Thanks for your work on this! I made a couple of changes. Running something like this scaled all vectors, including the crystallographic axes. I added an "is_axis" flag to the VectorArrow, which lets us control the vector annotation scale separate from the axes. xyzrender examples/structures/caffeine_cell.xyz --cell --vectors examples/strucutres/ethanol_dip.json --vector-scale 10 Stylistically, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug for still images of pbc systems with both axes and custom vectors requested where neither or only one was shown.
I made additional changes to treat these two vector sources the same by combining the sources of vectors early, so a consistent set of transformations can be applied without duplicating work.
I also unified the scattered means by which rotation is applied so it is the same scheme for vectors, the lattice box and all tests.