Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressed issue 428 #430

Closed
wants to merge 2 commits into from
Closed

Conversation

davidecoccia
Copy link

implements enhancement described in issue 428

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (00dd023) 100.00% compared to head (bde2542) 99.89%.

Files Patch % Lines
flask_limiter/util.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #430      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files            9        9              
  Lines          963      965       +2     
===========================================
+ Hits           963      964       +1     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisaifee
Copy link
Owner

@davidecoccia closing this PR for now - I would recommend that you simply implement your own get_... function explicitly in your application so that it's also very clear how it is being retrieved.

@alisaifee alisaifee closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants