-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates [test] #7579
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request involves updating translation files for multiple languages (Bulgarian, German, Spanish, French, Portuguese, and Ukrainian) with consistent changes to visibility and membership settings for Spaces and Subspaces. The modifications primarily focus on adding clear descriptions for public and private subspaces, updating membership requirement explanations, and ensuring consistent formatting across different language files. The changes aim to provide more precise and user-friendly descriptions of how Spaces and Subspaces can be accessed and joined. Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
🧹 Nitpick comments (1)
src/core/i18n/nl/translation.nl.json (1)
2909-2944
: Consider removing duplicate tags in space filters.The space filter configuration contains identical tags for each category. For example:
"tags": [ "Energie Transitie", "Energietransitie" ]This appears to be redundant as both tags are identical except for spacing.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
src/core/i18n/bg/translation.bg.json
(8 hunks)src/core/i18n/de/translation.de.json
(8 hunks)src/core/i18n/es/translation.es.json
(8 hunks)src/core/i18n/fr/translation.fr.json
(8 hunks)src/core/i18n/nl/translation.nl.json
(52 hunks)src/core/i18n/pt/translation.pt.json
(8 hunks)src/core/i18n/ua/translation.ua.json
(9 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
src/core/i18n/nl/translation.nl.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/pt/translation.pt.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/de/translation.de.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/fr/translation.fr.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/es/translation.es.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/bg/translation.bg.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/ua/translation.ua.json (1)
Pattern src/**/*.json
: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
🔇 Additional comments (29)
src/core/i18n/bg/translation.bg.json (2)
2020-2022
: LGTM! Clear and accurate translations for visibility settings.The translations for private and public Subspace visibility options are well-structured, maintain proper HTML formatting, and accurately convey the intended meaning.
2034-2034
: LGTM! Clear and accurate translation for membership settings.The translation for the "No Application required" membership option is well-structured, maintains proper HTML formatting, and accurately conveys the intended meaning.
src/core/i18n/ua/translation.ua.json (4)
467-467
: LGTM: Time formatting string added correctly.The timeAgo string is properly implemented with the {{time}} variable placeholder.
2020-2022
: LGTM: Visibility settings translations are clear and well-structured.The translations effectively communicate the visibility concepts while maintaining consistent HTML formatting with proper emphasis using
<b>
tags.
2034-2034
: LGTM: Open membership description is accurate and well-formatted.The translation clearly explains the open membership concept while maintaining consistent HTML formatting.
2283-2292
: LGTM: Tag suggestions array is well-structured.The array contains relevant tags that are commonly used, maintaining English terms for consistency across different language versions.
src/core/i18n/es/translation.es.json (4)
2020-2022
: LGTM! Clear and accurate visibility descriptions.The visibility descriptions for public and private subspaces are well-structured and effectively communicate the access levels and permissions.
2034-2034
: LGTM! Clear membership setting description.The description accurately explains the "No Application required" membership setting and its implications.
2283-2292
: LGTM! Well-structured search suggestions.The search suggestions array contains relevant and diverse terms that align with the platform's focus areas.
2710-2724
: LGTM! Clear Virtual Contributor settings.The Virtual Contributor settings are well-structured and provide clear descriptions for knowledge base and privacy settings.
src/core/i18n/pt/translation.pt.json (4)
2020-2021
: LGTM! Space visibility translations are accurate and clear.The translations for public and private space visibility settings maintain proper formatting and clearly explain the visibility implications.
2021-2022
: LGTM! Subspace visibility translations are accurate and clear.The translations for public and private subspace visibility settings maintain proper formatting and clearly explain the visibility implications, including the relationship with parent spaces.
2034-2034
: LGTM! Membership setting translation is accurate and clear.The translation for the "No Application required" membership setting maintains proper formatting and clearly explains the membership implications.
2283-2292
: LGTM! Search suggestion keywords are appropriate.The array of search suggestion keywords covers relevant domains and is appropriately kept in English for search functionality.
src/core/i18n/de/translation.de.json (5)
2020-2021
: Space visibility translations look good!The translations for public and private space visibility settings are accurate and maintain consistent terminology with the rest of the platform.
2021-2022
: Subspace visibility translations are well implemented!The new translations for public and private subspace visibility settings align well with the platform's terminology and effectively communicate the visibility concepts.
2034-2034
: Membership settings translation is accurate!The translation for the "No Application required" membership option is clear and consistent with the platform's terminology.
2283-2292
: Membership suggestions array is well structured!The array of suggested search terms is relevant and covers appropriate topics for the platform's focus areas.
2710-2724
: Virtual Contributor settings translations are complete!The translations for Virtual Contributor knowledge base and privacy settings maintain consistent terminology and effectively communicate the concepts.
src/core/i18n/nl/translation.nl.json (10)
175-177
: LGTM! Button translations are accurate and consistent.The Dutch translations for "notifications", "invite" and "visit" buttons maintain consistency with the platform's terminology.
184-184
: LGTM! Sign-in text follows platform conventions.The translation "Inloggen | Aanmelden" correctly uses the standard Dutch terms for login/signup actions.
221-221
: LGTM! Proper Dutch spelling used for "Beta".The translation correctly uses "Bèta" with the proper Dutch diacritic mark.
257-257
: LGTM! Common terms are properly translated.The translations for filter ("Filter op...") and email ("E-mail") follow Dutch language conventions with proper hyphenation.
Also applies to: 259-259
455-463
: LGTM! Role translations are accurate and consistent.The translations for various platform roles maintain consistency and use appropriate Dutch terminology for administrative positions.
2020-2022
: LGTM! Visibility settings are clearly translated.The translations for public/private visibility settings are clear and maintain proper Dutch grammar while explaining the concepts.
2027-2034
: LGTM! License and membership features are well translated.The translations for license features and membership settings use appropriate Dutch terminology and maintain clarity.
3011-3014
: LGTM! Plan features are clearly translated.The translations for the free plan features are clear and maintain proper Dutch grammar.
3081-3082
: LGTM! Virtual Contributor terms are properly translated.The translations for "Knowledge Base" and related text maintain consistency with the platform's terminology.
3128-3138
: LGTM! Document handling translations are accurate.The translations for document management features are clear and maintain proper Dutch grammar and terminology.
This is a test, please verify if the changes are accurate
Summary by CodeRabbit
Release Notes
Internationalization Updates
Language Support
These updates aim to provide clearer, more consistent user guidance across different language versions of the platform.