-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow paste of images from internet in MD editor. #7653
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Thank you for your effort on this! The check you have removed in this PR is not redundant as it checks whether the pasted image is copied from the internet as HTML, but what you have wrote me here makes me wonder do we want such requirement - to copy text and image and paste it at once? CC: @SimoneZaza - do we want our users to be able to copy text + images and paste them all together in our MD editor? |
Closing as the implementation was transferred to: #7659 |
It looked straightforward, but @reactoholic please double-check it.
I think there was a redundant isImage check. We can probably further optimize and reduce code.
Note that I'm now able to paste entire block with text and images form the internet.
However, when coping files locally, only one is uploaded.