Merge pull request #36 from allaboutapps/feature/logging-performance-…

…improvement Checking verbose before doing parsing, decoding, prettyfying
allaboutapps · Jul 17, 2023 · 5797aef · 5797aef
2 parents 18c9251 + 1dc88f2
commit 5797aef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Sources/Fetch/Network/APILogger.swift b/Sources/Fetch/Network/APILogger.swift
@@ -51,15 +51,15 @@ public class APILogger: EventMonitor {
         output.append("↗️\(isStubbed ? " [STUB]" : "") \(urlRequest.httpMethod ?? "") - \(urlRequest.url?.absoluteString ?? "")")
 
         let spacing = "         "
-        if let headers = urlRequest.allHTTPHeaderFields, verbose {
+        if verbose, let headers = urlRequest.allHTTPHeaderFields {
             output.append("\(spacing)Headers:")
             let formattedHeaders = headers
                 .map { "\(spacing)   \($0.0): \($0.1)" }
                 .joined(separator: "\n")
             output.append(formattedHeaders)
         }
 
-        if let body = prettyJSON(data: urlRequest.httpBody), verbose {
+        if verbose, let body = prettyJSON(data: urlRequest.httpBody) {
             output.append("\(spacing)Request Body:")
             output.append(body)
         }
@@ -86,8 +86,9 @@ public class APILogger: EventMonitor {
 
         output.append("\(icon)\(isStubbed ? " [STUB]" : "") \(response.statusCode) \(urlRequest.httpMethod ?? "") - \(urlRequest.url?.absoluteString ?? "")")
 
-        if let data = (request as? DataRequest)?.data,
-            let body = prettyJSON(data: data) ?? String(data: data, encoding: .utf8), verbose {
+        if verbose,
+           let data = (request as? DataRequest)?.data,
+           let body = prettyJSON(data: data) ?? String(data: data, encoding: .utf8) {
             output.append(body)
         }
 

diff --git a/Tests/FetchTests/Cache/CacheTests.swift b/Tests/FetchTests/Cache/CacheTests.swift
@@ -312,7 +312,7 @@ class CacheTests: XCTestCase {
             }
         }
 
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
+        DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
             resource.fetch { (result, isFinished) in
                 switch result {
                 case let .success(.cache(value, isExpired)):