Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled TLS certificate verification in get_vault_token() #357

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Enabled TLS certificate verification in get_vault_token() #357

merged 6 commits into from
Feb 23, 2023

Conversation

artnowo-alle
Copy link
Contributor

No description provided.

@artnowo-alle artnowo-alle force-pushed the tls-cert-verification branch from 9ca910c to 7e95666 Compare January 31, 2023 08:46
iwko
iwko reviewed Feb 1, 2023
View reviewed changes
bigflow/cli.py Show resolved Hide resolved
@artnowo-alle artnowo-alle marked this pull request as ready for review February 20, 2023 12:03
agnieszkarybak
agnieszkarybak reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@agnieszkarybak agnieszkarybak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'm a coauthor ;)

bigflow/_version.py
@@ -1 +1 @@
__version__ = '1.5.4'
__version__ = '1.6.0.dev1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be changed to '1.6.0'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do on a release branch

@artnowo-alle artnowo-alle changed the base branch from master to release/1.6.0 February 21, 2023 07:55
@artnowo-alle artnowo-alle merged commit fab2660 into release/1.6.0 Feb 23, 2023
@artnowo-alle artnowo-alle mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwko iwko iwko left review comments

@agnieszkarybak agnieszkarybak agnieszkarybak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artnowo-alle @iwko @agnieszkarybak