Fix bf for composer in version 2 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distinguish code
… distinguish code
Add changes with fixing tests
… distinguish code
… distinguish code
thegunner157
force-pushed
the
fix_bf_for_composer_in_version_2
branch
from
7356c34 to
ed18252
Compare
bigflow/dagbuilder.py
Outdated
| @@ -66,8 +66,9 @@ def generate_dag_file( | |||
| from airflow.contrib.kubernetes.secret import Secret | |||
| from airflow.contrib.operators.kubernetes_pod_operator import KubernetesPodOperator | |||
|
|
|||
| # BigFlow assumes that you use (airflow 1.x + composer 1.x) or (airflow 2.x + composer 2.x) | |||
| # BigFlow assumes that we use (airflow 1.x + composer 1.x) or (airflow 2.x + composer 2.x) | |||
There was a problem hiding this comment.
it's just language comment but maybe instead of "BF assumes" you can put it like "To deploy BigFlow project, following requirements options are needed: ...".
…' into fix_bf_for_composer_in_version_2 # Conflicts: # bigflow/dagbuilder.py # test/dagbuilder/my_daily_workflow__dag.py.txt # test/dagbuilder/my_parametrized_workflow__dag.py.txt # test/dagbuilder/my_workflow__dag.py.txt
alicja-nowak-allegro
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.