Information bubble #3887
Merged
Information bubble #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CloudHost, BaseObjectsSupport for users in information bubbles
matyldv
previously approved these changes
Mar 18, 2025
awieckowski
reviewed
Mar 18, 2025
| migrations.RemoveField( | ||
| model_name='servicebasedinformationbubble', | ||
| name='groups', | ||
| ), |
There was a problem hiding this comment.
so migration 0002 is not really needed?
There was a problem hiding this comment.
Yeah, they could've been squashed into 1. Now it's 1
|
I know this PR is almost finished. I'm afraid, Information Bubble is non standard and quite confusing name, isn't it ? Did we evaluate other choices ? A few options:
Alternatives
|
awieckowski
approved these changes
Mar 24, 2025
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit visibility of hosts (data center asset, virtual server, cluster, cloud host) for users in information bubble
User in an information bubble or in a group which is in an information bubble will see limited assets - asset must belong to the service env of a service which belongs to at least 1 of user's information bubble.
BaseObjectsSupport visibility is also limited (but not Support visibility as it's less clear how to do that)