Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default timeout from 5s to 30s #284

Merged
merged 1 commit into from
Aug 30, 2024
Merged

increase default timeout from 5s to 30s #284

merged 1 commit into from
Aug 30, 2024

Conversation

stupendousC
Copy link
Contributor

Parent ticket & assoc'd ReOps ticket

TLDR = beaker.experiment.list() take take ~15 seconds depending on query, so let's increase the default timeout.

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just update the changelog?

@stupendousC stupendousC merged commit 893bf67 into main Aug 30, 2024
19 checks passed
@stupendousC stupendousC deleted the incrTimeout branch August 30, 2024 22:09
@stupendousC
Copy link
Contributor Author

FYI for future self, after merging PR, need to first manually update version (but no need to inc that in PR), then follow https://github.com/allenai/beaker-py/blob/main/RELEASE_PROCESS.md. Will see version.py updated afterwards.

@stupendousC
Copy link
Contributor Author

stupendousC commented Aug 30, 2024

oops, failed release bc I think I forgot to add '### Added' to CHANGELOG.md. Revert & fix!. Nope, can't revert, ok, just fix it in next PR then. Then retry release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants