Skip to content

Refactors the loss calculation to pull it out into a free function #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Refactors the loss calculation to pull it out into a free function #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d35b4dd
First commit.
finbarrtimbers Nov 3, 2025
8b0b252
Merge branch 'main' into refactor-loss
finbarrtimbers Nov 3, 2025
2d450c2
Cleaned up code
finbarrtimbers Nov 3, 2025
41bdc23
Added metrics class
finbarrtimbers Nov 3, 2025
e8b6f32
Updated code
finbarrtimbers Nov 3, 2025
d677b33
cleaned up code
finbarrtimbers Nov 5, 2025
4f15218
Cleaned up code
finbarrtimbers Nov 5, 2025
783579d
Merge branch 'main' into refactor-loss
finbarrtimbers Nov 6, 2025
abe4387
updated code to remove metricstracker
finbarrtimbers Nov 6, 2025
3f716d6
Updated code
finbarrtimbers Nov 6, 2025
196a26b
Update code
finbarrtimbers Nov 6, 2025
adb108b
Added tests
finbarrtimbers Nov 7, 2025
679351d
Merge branch 'main' into refactor-loss
finbarrtimbers Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@
- To run the `./scripts/train/build_image_and_launch.sh` script, you must commit the current changes.
- Launch tool use experiments by running `./scripts/train/build_image_and_launch.sh scripts/train/debug/tool_grpo_fast.sh`.
- Launch multi-node non-tool experiments by running `./scripts/train/build_image_and_launch.sh scripts/train/debug/large_test_script.sh`.

# Comments Policy
- NEVER remove existing comments from code when making edits unless they are obviously outdated, in which case ALWAYS ask for permission.
- Always preserve all existing comments, especially explanatory ones
- Only add comments when they are needed for clarity
Loading
Loading