set to augusta when specified

[saumyamalik]

Note

Updates eval script to turn off WEKA mounts when targeting augusta and to use a per-user HF_TOKEN secret derived from the Beaker username.

• scripts/eval/oe-eval.sh
  • Cluster/WEKA logic: Set EVALUATE_ON_WEKA=false when --cluster contains augusta (in addition to gs:// models).
  • Gantry args:
    • Derive whoami from beaker account whoami.
    • Use user-scoped HF secret: env-secret#2: HF_TOKEN=${whoami}_HF_TOKEN in both WEKA and non-WEKA paths.

^{Written by Cursor Bugbot for commit df49429. This will update automatically on new commits. Configure here.}

[gemini-code-assist]

Summary of Changes

Hello @saumyamalik, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the evaluation environment setup by introducing a condition that disables WEKA evaluation when the target cluster is identified as 'augusta'. This change ensures that the evaluation process correctly adapts to specific cluster configurations, providing more accurate control over resource utilization based on the deployment environment.

Highlights

• Evaluation Logic Update: The script now checks if the CLUSTER variable contains 'augusta' in addition to checking the MODEL_LOCATION for 'gs://' to determine whether to set EVALUATE_ON_WEKA to 'false'.
• Documentation: A new comment has been added to scripts/eval/oe-eval.sh to explicitly state that if the specified CLUSTER contains 'augusta', evaluate_on_weka will be set to 'false'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the evaluation script to disable WEKA mounts and force execution on the 'augusta' cluster when 'augusta' is part of the specified cluster list. The implementation is straightforward. I have one suggestion to make the cluster detection logic more robust to prevent potential false-positive matches with cluster names that might contain 'augusta' as a substring.

[gemini-code-assist]

The glob pattern *augusta* is a bit too broad and could lead to false positives. For example, a cluster named my-augusta-test would match, but a hypothetical cluster named notaugusta would also match, which is likely not the desired behavior. Using a regular expression with word boundaries (\b) would make this check more robust by matching augusta as a whole word.

Suggested change

	if [[ "$MODEL_LOCATION" == gs://* || "$CLUSTER" == *augusta* ]]; then
	if [[ "$MODEL_LOCATION" == gs://* || "$CLUSTER" =~ \baugusta\b ]]; then

[saurabh111233212]

its ok gemini dw abt it

[saurabh111233212]

maybe we shouldn't use saumya's HF TOKEN, should probably pull the whoami using beaker CLI