legacypool_test.go: fix TestDualHeapEviction #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allformless
approved these changes
Jan 7, 2026
allformless
merged commit 5d1a60a
into
allformless:upstream-geth-v-1-16-7-fix
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestDualHeapEviction was failing because the pool size (4) was too small.
The floatingCount calculation uses integer division:
len(urgent) * 1 / 5 = 0,leaving the floating heap empty and high gasFeeCap transactions unprotected.
Increased pool capacity from 4 to 20 transactions:
This makes floatingCount = 4, properly activating dual heap protection.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: