Skip to content

core: fix core ut#19

Merged
allformless merged 1 commit intoallformless:upstream-geth-v-1-16-7-fixfrom
zlacfzy:fix_core_ut
Jan 7, 2026
Merged

core: fix core ut#19
allformless merged 1 commit intoallformless:upstream-geth-v-1-16-7-fixfrom
zlacfzy:fix_core_ut

Conversation

@zlacfzy
Copy link

@zlacfzy zlacfzy commented Jan 7, 2026

Description

1. Fix p256Verify precompile test (core/vm/contracts_test.go)

Added missing eip7951: true field to the p256Verify precompile instance in the test's allPrecompiles map to match the expected configuration.

2. Fix number variable type in chain freezer (core/rawdb/chain_freezer.go)

Problem:
The number variable was declared as *uint64 (pointer) but was being used in contexts that expected a value type.

Fix:
Changed number from *uint64 to uint64 and removed the dereference operators (*number) in the subsequent usages.

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@allformless allformless merged commit 970aaf9 into allformless:upstream-geth-v-1-16-7-fix Jan 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants