Skip to content

core: fix TestWaitDeployedCornerCases#21

Merged
allformless merged 1 commit intoallformless:upstream-geth-v-1-16-7-fixfrom
zlacfzy:fix_account_test
Jan 7, 2026
Merged

core: fix TestWaitDeployedCornerCases#21
allformless merged 1 commit intoallformless:upstream-geth-v-1-16-7-fixfrom
zlacfzy:fix_account_test

Conversation

@zlacfzy
Copy link

@zlacfzy zlacfzy commented Jan 7, 2026

Description

1wei tip will be reject by miner.

// DefaultConfig contains default settings for miner.
var DefaultConfig = Config{
	GasCeil:  100000000,
	GasPrice: big.NewInt(params.GWei),
	// The default recommit time is chosen as two seconds since
	// consensus-layer usually will wait a half slot of time(6s)
	// for payload generation. It should be enough for Geth to
	// run 3 rounds.
	Recommit:      &defaultRecommit,
	DelayLeftOver: &defaultDelayLeftOver,

	// The default value is set to 45 seconds.
	// Because the avg restart time in mainnet could be 30+ seconds, so the node try to wait for the next multi-proposals to be done.
	MaxWaitProposalInSecs: &defaultMaxWaitProposalInSecs,

	Mev: DefaultMevConfig,
}

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@allformless allformless merged commit 6f976ff into allformless:upstream-geth-v-1-16-7-fix Jan 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants