Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KANBAN-584 pavi integration #1345

Merged
merged 5 commits into from
Jul 29, 2024
Merged

KANBAN-584 pavi integration #1345

merged 5 commits into from
Jul 29, 2024

Conversation

mluypaert
Copy link
Member

Enabling intergration of constants and related functions into the PAVI UI (to enable reused of jbrowse configs) through the updates in this PR.

motenko and others added 5 commits May 17, 2024 15:18
Push test into main for KANBAN-561 and KANBAN-568
Fixing the phenotype annotation linkouts
SCRUM-4182 Remove linkouts to gene type phenotype annotations
@mluypaert mluypaert marked this pull request as ready for review July 25, 2024 20:37
Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically the .js is omitted when doing includes for JS.

@mluypaert
Copy link
Member Author

Typically the .js is omitted when doing includes for JS.

Ya, while I am aware of that, doing so means I cannot import this modules through it's raw github https URL, because the relative paths don't resolve without their extensions. Including the extension does work though in all cases (both for local paths as through URL imports).

@mluypaert
Copy link
Member Author

And I need to import through URL as these files are not local to the PAVI code, nor deployed and installable through npm (and probably should not be either).

@mluypaert mluypaert requested a review from adamgibs July 26, 2024 09:09
mluypaert added a commit to alliance-genome/agr_pavi that referenced this pull request Jul 26, 2024
alliance-genome/agr_ui#1345 needs merging to test
and later main branch, before updating URL to import from main branch before merging to PAVI main branch.
@mluypaert mluypaert merged commit c304f1e into test Jul 29, 2024
2 checks passed
@mluypaert mluypaert deleted the KANBAN-584_pavi-integration branch July 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants