Skip to content

Conversation

mixern6
Copy link

@mixern6 mixern6 commented Oct 1, 2023

The "baseplayer_shared.h" include goes with a lot of non-working code and can't be compiled.
As it is not required in IVehicle.h it can be removed.
The "platform.h" is still needed for the abstract_class key word.

@GAMMACASE
Copy link
Member

You probably wanted to target cs2 branch instead of csgo?

@mixern6
Copy link
Author

mixern6 commented Oct 2, 2023

You probably wanted to target cs2 branch instead of csgo?

I'd like to target both.
@GAMMACASE Please, cherry-pick this change to all the branches.

@Kenzzer
Copy link
Member

Kenzzer commented Sep 24, 2025

If this causes trouble, issue can be worked around by defining #define BASEPLAYER_SHARED_H thereby triggering the include guard of baseplayer_shared.h. Metamod (and sourcemod) do similar hacks to be compiled with other sdk headers.

Is this still something that we want to see merged or should the PR be closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants