Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Update Install.sh to detect and handle Conda env #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gb96
Copy link

@gb96 gb96 commented Aug 16, 2022

Check for virtual env as previously,
if no virtual env add a check to see if we have an active conda env.
If there is no virtual env but we have a conda env, treat the conda env like a virtual env.

Tested using conda 4.12.0 on Ubuntu 20.04.4 LTS

Check for virtual env as previously,
    if no virtual env add a check to see if we have an active conda env.
      If there is no virtual env but we have a conda env, treat the conda env like a virtual env.

Tested using conda 4.12.0 on Ubuntu 20.04.4 LTS
@gb96
Copy link
Author

gb96 commented Aug 16, 2022

I have proposed this change to assist other developers that use a conda virtual environment (comes with Anaconda or Miniconda).
Without this change the Install.sh does not detect a conda environment and will instead ask the user to run Install.sh as root.
With this change, an active conda env is detected and treated the same as for a virtual env, which produces the desired result.

@NiklasKroeger-AlliedVision
Copy link
Collaborator

Thank you very much for your suggestion! I will see when I can schedule some time to look into this and test the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants