feat(layers): Port middleware (layers) from ethers-rs
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Mar 15, 2024
zerosnacks
force-pushed
the
zerosnacks/middleware
branch
from
5117de4
to
35b3a2f
Compare
mattsse
requested changes
Mar 21, 2024
|
Merging this, requested changes were addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To add examples from
ethers-rs:middleware(layers)Solution
Implements a subset of the examples from
ethers-rs, specifically theNonceManagerMiddlewareand theSignerMiddleware.Currently not implemented as an example, due to the implementation missing in Alloy:
GasEscalatorMiddlewareGasOracleMiddlewarePolicyMiddlewareSome examples are not implemented due to the builder pattern being used throughout all examples in Alloy.
CustomMiddlewarehas not been implemented yet as I think it likely will require some implementation work to be able to define a robust way of handling this. Users can refer to the existing implementations as a starting point.I've decided to refer to these as
layersrather thanether-rs'smiddleware.