-
Notifications
You must be signed in to change notification settings - Fork 5
6주차 미션 구현 완료(정규호) #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kokkumong
wants to merge
1
commit into
allrounder-backend:main
Choose a base branch
from
kokkumong:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| package calculator; | ||
|
|
||
| import calculator.controller.CalculatorController; | ||
|
|
||
| public class Application { | ||
| public static void main(String[] args) { | ||
| // TODO: 프로그램 구현 | ||
| CalculatorController controller = new CalculatorController(); | ||
| controller.run(); | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
src/main/java/calculator/controller/CalculatorController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package calculator.controller; | ||
|
|
||
| import calculator.model.Calculator; | ||
| import calculator.view.InputView; | ||
| import calculator.view.OutputView; | ||
|
|
||
| public class CalculatorController { | ||
| public void run() { | ||
| try { | ||
| String input = InputView.getInput(); | ||
| int result = Calculator.add(input); | ||
| OutputView.printResult(result); | ||
| } catch (IllegalArgumentException e) { | ||
| OutputView.printError(e.getMessage()); | ||
|
|
||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package calculator.model; | ||
|
|
||
| public class Calculator { | ||
| public static int add(String input) { | ||
| if (input == null || input.isEmpty()) { | ||
| return 0; | ||
| } | ||
|
|
||
| String delimiter = ",|:"; | ||
|
|
||
| if (input.startsWith("//")) { | ||
| int delimiterIndex = input.indexOf("\n"); | ||
| if (delimiterIndex == -1) { | ||
| throw new IllegalArgumentException("잘못된 구분자 형식입니다."); | ||
| } | ||
|
|
||
| String customDelimiter = input.substring(2, delimiterIndex); | ||
| if (customDelimiter.isEmpty()) { | ||
| throw new IllegalArgumentException("커스텀 구분자가 비어 있습니다."); | ||
| } | ||
|
|
||
| delimiter = customDelimiter; | ||
| input = input.substring(delimiterIndex + 1); | ||
| } | ||
|
|
||
| String[] tokens = input.split(delimiter); | ||
| int sum = 0; | ||
|
|
||
| for (String token : tokens) { | ||
| if (token.isEmpty()) continue; | ||
|
|
||
| try { | ||
| int number = Integer.parseInt(token.trim()); | ||
| sum += number; | ||
| } catch (NumberFormatException e) { | ||
| throw new IllegalArgumentException("숫자가 아닌 값이 포함되어 있습니다: " + token); | ||
| } | ||
| } | ||
|
|
||
| return sum; | ||
|
Comment on lines
+4
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add 하나에 너무 많은 기능이 있는 거 같아요. 의존성 분리를 하는 것을 어떨까요? |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package calculator.view; | ||
|
|
||
| import java.util.Scanner; | ||
|
|
||
| public class InputView { | ||
| public static String getInput() { | ||
| Scanner scanner = new Scanner(System.in); | ||
| System.out.print("계산할 문자열을 입력하세요: "); | ||
| return scanner.nextLine(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package calculator.view; | ||
|
|
||
| public class OutputView { | ||
| public static void printResult(int result) { | ||
| System.out.println("계산 결과: " + result); | ||
| } | ||
|
|
||
| public static void printError(String message) { | ||
| System.err.println("오류: " + message); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stream api를 사용하는 것도 좋을 거 같아요