Open
Conversation
위도, 경도 바탕으로 60km/h으로 갈 때 이동 시간 구하기 완료
There was a problem hiding this comment.
Controller가 추가될 수도 있기 때문에 좀 더 구체적인 이름으로 바꾸셔도 좋을 것 같아요
There was a problem hiding this comment.
이 클래스는 record타입으로 바꿀 수 있을 거 같습니다
There was a problem hiding this comment.
이 클래스에서 장소관리, 거리계산까지 다 하고 있는데 책임분리를 좀 더 할 수 있는 방향으로 고칠 수 있을 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allrounder-Study-Mission-PR
[운송(배송)] 미션 구현 (이상호)
💡 Summary
구현한 기능
✅ CheckList
신경써서 구현한 점 / 어려웠던 점
📚 Retrospective (YWT)
What I did
What I Learned
What I will do next
✨ Impression
단위테스트에 대해 더 공부해봐야겠다.