Open
Conversation
ddoddogga
reviewed
Aug 16, 2025
| @Log(LogLevel.DEBUG) | ||
| public static void main(String[] args) { | ||
| //TODO: 미션 구현 | ||
| CompositionRoot compositionRoot = new CompositionRoot(); |
There was a problem hiding this comment.
오 구성루트를 메인에 구현하지 않고 따로 만든 게 깔끔하고 좋은 거 같아요
ddoddogga
reviewed
Aug 17, 2025
| validateDifferentPlaces(fromName, toName); | ||
|
|
||
| PlaceWithPositionDto fromPlaceWithPosition = placeService.getPlaceWithPosition(fromName); | ||
| PlaceWithPositionDto toPlaceWithPosition = placeService.getPlaceWithPosition(toName); |
|
|
||
| import mission.common.log.LogLevel; | ||
|
|
||
| public final class AppConfig { |
| private AppConfig() {} | ||
|
|
||
| public static double speedKmPerHour() { | ||
| String prop = System.getProperty("speed.kmph"); |
There was a problem hiding this comment.
JVM 시스템 프로퍼티(System Property)를 통해 속도를 가져오는 것이네요. 속도를 변경할 수 있게 만든 점이 좋네요.
아래 if문 두 개는 합쳐도 될 것 같네요.
| return LogLevel.valueOf(prop.trim().toUpperCase()); | ||
| } catch (IllegalArgumentException e) { | ||
| mission.common.log.Logger.log(AppConfig.class, mission.common.log.LogLevel.WARN, | ||
| "Invalid log level configuration: " + prop + ", using default: " + DEFAULT_LOG_LEVEL); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
2시간 반 밖에 투자하지못했습니다;.......죄송합니다 코드를 쌌습니다............
✅ CheckList
신경써서 구현한 점 / 어려웠던 점
-> 자바스터디가 아니라 커서스터디를 했다.
📚 Retrospective (YWT)
What I did
What I Learned
그외에도 validate를 그냥 도메인로직안에 둔다든가, 아니면 error enum을 안짜준다든가
근데 이건 지금 생각해보니까 이게 더 가독성에 도움이 될지도
What I will do next
✨ Impression
죄송합니다..................................이후 확장하면서 제 똥같은 코드를 고치고 그에 대한 자세한 문제해결과정 남겨놓겠습니다....