[운송II - 주문]미션 구현 (정규호)#9
Open
kokkumong wants to merge 8 commits intoallrounder-backend:mainfrom
Hidden character warning
The head ref may contain hidden characters: "6\uc8fc\ucc28"
Open
Conversation
ddoddogga
reviewed
Aug 20, 2025
| this.output = output; | ||
| } | ||
|
|
||
| public void run(){ |
| throw new IllegalArgumentException("입력 형식이 올바르지 않습니다. (예: 출발지-도착지(이름))"); | ||
| } | ||
| String[] parts = new String[3]; | ||
| String regex = "(.+)-(.+)\\((.+)\\)"; |
daeGULLL
reviewed
Aug 25, 2025
daeGULLL
left a comment
daeGULLL
left a comment
There was a problem hiding this comment.
헥사고날 아키텍쳐를 잘 사용하신 것 같아요! 사소한 제안점들만 검토해주시면 더 훌륭한 코드가 될 것 같습니다. 수고하셨어요~
| } | ||
| catch(FileNotFoundException e){ | ||
| System.err.println("position.csv : 파일을 찾을 수 없습니다."); | ||
| } |
There was a problem hiding this comment.
suggestion : 이런 예외들이 반복되는 상황이라, 따로 exception 디렉토리를 만들어서 예외들을 관리하는 방안이 나을 것 같아요. 커스텀 예외 클래스에서 받는 파라미터에 위치 String을 입력하게 하면 깔끔하게 관리할 수 있을거에요. Static factory 패턴을 이용한 예외 클래스 제작이 회의방의 메세지에 있으니 참고하세요.
|
|
||
| @Override | ||
| public void startDelivery(int id, Duration deliveryDuration){ | ||
| int totalMinutes = (int) deliveryDuration.toMinutes(); |
There was a problem hiding this comment.
nitpick : 이렇게 계산이 필요한 데이터를 받는 것은 의존성이 강해진다고 판단해서, 외부에서 계산을 거친 duration 내부의 값들만 parameter로 받게끔 하는게 나을 것 같아요. ex) startDelivery(int id, int hour, int minute). 아니면 계산을 거친 값들만 dto에 저장하게 해도 좋을 것 같네요.
| public int getPlaceId() { | ||
| return placeId; | ||
| } | ||
|
|
There was a problem hiding this comment.
nitpick : 이렇게 단순히 get, set만 하는 모델의 경우에는 record로 만드는 것이 더 간편해요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.