Open
Conversation
moongua404
reviewed
Apr 28, 2025
| if (ink < requiredInk) return false; | ||
| ink -= requiredInk; | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
의미를 잉크 사용에 둔다면 반환형을 없애고 예외로 처리해도 괜찮을거같아요
| } | ||
| output.append(System.lineSeparator()); | ||
| } | ||
| view.displayAscii(output.toString()); |
Contributor
There was a problem hiding this comment.
가독성이 떨어지는 것 같아요
stream API로 충분히 대체 가능할 것 같아요
|
|
||
| import java.util.List; | ||
|
|
||
| public class Printer { |
Contributor
There was a problem hiding this comment.
printer를 모델로 두셨나요? 모델로 두셨다면 MVC 패턴 상에서 뷰의 의존성을 모델이 지고 있는게 부적절한 것 같아요.
| view.displayMessage("프로그램을 종료합니다."); | ||
| break; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
급하게 구현해서 여기저기 이상한 부분이 많습니다.
시간이 많지 않아 기능 구현에만 집중했습니다.