Fix waveform and iOS compilation issue #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarklBcm
pushed a commit
to bcm-it-team/flutter_soloud
that referenced
this pull request
Sep 24, 2024
…equoia Fix waveform and iOS compilation issues # Conflicts: # .vscode/tasks.json # example/pubspec.lock # src/player.h
|
[nit] I think raising deployment target is definitely a breaking change. In the future, we should consider only doing it between major semver updates. This change broke the codelab and therefore might have broken others' code, too. (Just to be clear, I'm glad these fixes landed regardless, and having the iOS version at |
|
Sorry, I had to think of that! 🫣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #129
fix #128
fix #130
Type of Change
The waveform generation (on C+ side) used float numbers, but higher precision was needed to compute the waveform. Changing to
doubles fixed the issue!Minor changes for the other 2 issues that fix compiling on iOS.