Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loadAsset future does not fail when an error loading the file occurs. #146

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: loadAsset future does not fail when an error loading the file occurs. #146

merged 1 commit into from
Oct 29, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Oct 29, 2024

Description

fixes #145

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak merged commit 8d9d1ba into main Oct 29, 2024
1 check passed
@alnitak alnitak deleted the throw_load_filed branch October 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: SoLoud.instance.loadAsset future does not fail when an error loading the file occurs.
1 participant
@alnitak