Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLoopPoint now returns Duration #71

Merged
merged 3 commits into from
Mar 29, 2024
Merged

getLoopPoint now returns Duration #71

merged 3 commits into from
Mar 29, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Mar 29, 2024

Description

  • getLoopPoint now returns Duration
  • loop test added

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak requested a review from filiph March 29, 2024 13:03
filiph
filiph approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@alnitak alnitak changed the title updated CHANGELOG getLoopPoint now returns Duration Mar 29, 2024
@alnitak alnitak merged commit 0ce67fb into main Mar 29, 2024
1 check passed
@alnitak alnitak deleted the tests branch March 29, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnitak @filiph