[WIP] Major refactoring: bayex -> bojax #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonfnt
changed the title
The previous version of the code was slow and would yield wrong results due to a wrong assumption on the gaussian process. This version should fix that, as well as minimize the number of compilations the code does as it increases the size. This is still a minimal implementation with plenty of space for improvements, which can be added gradually and the codebase gets leaner. Nevertheless, the code should work as expected now.
Update Readme file to match with the new Bojax library.
The images in the readme were too large and couldn't fit next to each other.
alonfnt
force-pushed
the
bojax
branch
3 times, most recently
from
96ed6ba to
833b79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refractor considerably minimizes the amount of code and focuses on correctness and performance.
It introduces a minimal Bayesian optimization code that can be expanded upon.