Suggestion & minimal implementation: Vite build#39
Open
qq7 wants to merge 2 commits intoalonswartz:masterfrom
Open
Suggestion & minimal implementation: Vite build#39qq7 wants to merge 2 commits intoalonswartz:masterfrom
qq7 wants to merge 2 commits intoalonswartz:masterfrom
Conversation
Owner
|
Hey @qq7, thanks for that! My initial rationale was to keep it simple, and not require build dependencies. But, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Alon, it seemed a bit strange to me that you've decided to write your own bundling system instead of utilizing npm/yarn/pnpm (I went with pnpm in this pull request) with vite, the bundling tool introduced and maintained by vue team, so I decided to build this minimal example so that it's easier for you to evaluate it makes sense for you to use it in the future.
! I have not tested it with a running backend.
in
web/app/:dev environment with hmr:
production build:
This may also be extended with following improvements: