Merged PR 314: v1.32.1 - Fix an issue where protests in tossup-only p…

…ackets would crash MODAQ (#305)

- Fix an issue where protests in tossup-only packets would crash MODAQ
- Bump version to 1.32.1

package.json

@@ -1,6 +1,6 @@
 {
     "name": "modaq",
-    "version": "1.32.0",
+    "version": "1.32.1",
     "description": "Quiz Bowl Reader using TypeScript, React, and MobX",
     "repository": {
         "type": "git",

src/state/GameState.ts

@@ -238,10 +238,11 @@ export class GameState {
                         }
 
                         const bonusIndex: number = this.getBonusIndex(i);
-                        const potentialBonusPoints = this.packet.bonuses[bonusIndex].parts.reduce(
-                            (previous, current) => current.value + previous,
-                            0
-                        );
+                        const potentialBonusPoints =
+                            this.packet.bonuses[bonusIndex]?.parts.reduce(
+                                (previous, current) => current.value + previous,
+                                0
+                            ) ?? 0;
 
                         // Need to remove the neg (subtract) and add what the correct value would be
                         swings[tossupTeamIndex].for +=

tests/ProtestsMatterTests.ts

@@ -301,6 +301,52 @@ describe("GameStateTests", () => {
             );
             expect(game.protestsMatter).to.be.true;
         });
+        it("Tossup-only game, protest matters", () => {
+            const game: GameState = new GameState();
+            game.addNewPlayers(players);
+            const packet: PacketState = new PacketState();
+            packet.setTossups(defaultPacket.tossups);
+            game.loadPacket(packet);
+
+            game.setGameFormat({ ...game.gameFormat, negValue: -5 });
+            game.cycles[0].addWrongBuzz(
+                { player: firstTeamPlayer, points: 0, position: 2, isLastWord: false },
+                0,
+                game.gameFormat
+            );
+            game.cycles[0].addTossupProtest(firstTeamPlayer.teamName, 0, 2, "My answer", "My reason");
+            expect(game.protestsMatter).to.be.true;
+        });
+        it("Tossup-only game, protest doesn't matter", () => {
+            const game: GameState = new GameState();
+            game.addNewPlayers(players);
+            const packet: PacketState = new PacketState();
+            packet.setTossups(defaultPacket.tossups);
+            game.loadPacket(packet);
+
+            game.setGameFormat({ ...game.gameFormat, negValue: -5 });
+            game.cycles[0].addWrongBuzz(
+                { player: firstTeamPlayer, points: 0, position: 2, isLastWord: false },
+                0,
+                game.gameFormat
+            );
+            game.cycles[0].addTossupProtest(firstTeamPlayer.teamName, 0, 2, "My answer", "My reason");
+
+            game.cycles[1].addCorrectBuzz(
+                {
+                    player: firstTeamPlayer,
+                    points: 10,
+                    position: 1,
+                    isLastWord: false,
+                },
+                1,
+                game.gameFormat,
+                0,
+                0
+            );
+
+            expect(game.protestsMatter).to.be.false;
+        });
     });
 });