Fixed bug bit_id_to_ids

alpaca-tc · Apr 1, 2024 · c19ff16 · c19ff16
1 parent c91bccf
commit c19ff16
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/diver_down/web/bit_id.rb b/lib/diver_down/web/bit_id.rb
@@ -18,7 +18,7 @@ def bit_id_to_ids(bit_id)
           ids = []
           shift = 0
           while bit_id.positive?
-            if bit_id & 1
+            if (bit_id & 1) == 1
               ids.push(shift + 1)
             end
 

diff --git a/spec/diver_down/web/bit_id_spec.rb b/spec/diver_down/web/bit_id_spec.rb
@@ -23,6 +23,13 @@
 
         expect(described_class.bit_id_to_ids(int_or)).to eq(ids)
       end
+
+      it 'converts given specific bit_id to id' do
+        id = 1922
+        bit_id = described_class.ids_to_bit_id([id])
+
+        expect(described_class.bit_id_to_ids(bit_id)).to eq([id])
+      end
     end
   end
 end