Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper binding for property option type #756

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

uranio-235
Copy link
Contributor

proper binding for property option type

@uranio-235 uranio-235 changed the title Develop proper binding for property option type Oct 3, 2024
Copy link
Contributor

@ooples ooples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and have you done testing on your end with this change?

@uranio-235
Copy link
Contributor Author

uranio-235 commented Oct 3, 2024

Looks good to me and have you done testing on your end with this change?

Sadly I don't. Is too simple anyway. Just the property setter to work at the serialisation. I didn't found a test unit for this, but anyway, I did from a code space directly.

@OlegRa OlegRa self-assigned this Oct 17, 2024
@OlegRa OlegRa added the bug Something isn't working label Oct 17, 2024
@OlegRa OlegRa added this to the SDK 7.x LTS milestone Oct 17, 2024
Copy link
Collaborator

@OlegRa OlegRa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and sorry for the delayed review and merge

@OlegRa OlegRa merged commit 8137296 into alpacahq:develop Oct 17, 2024
3 checks passed
OlegRa pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants