fix: added type Position for getPosition function & getPositions; ext… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended BaseOrder type
|
One tiny change I would make, one sec. |
|
Thank you for the pr! I have been short on time so all help is appreciated :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I just wanted to say that your project is very helpful and well-organized. I've changed the return types of
getPositionandgetPositions, as well as made some modifications toBaseOrder. To be honest, I'm not entirely sure if my changes are correct, as I didn't find much information about the appropriate return types. I just looked at the responses I received.Would appreciate it if you could merge my changes so that I don't have to override the response type for these methods. Thanks!