Add checking end to end tests to PR review checklist #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We occasionally have cases where the end to end tests need to be changed to deploy changes because they rely on content in the app. It helps to think about this before merging a PR, so this commit adds a reminder to the PR review checklist to think about it.
|
jamie-o-wilkinson
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
This PR should have the same changes as alphagov/forms-admin#1870.
We occasionally have cases where the end to end tests need to be changed to deploy changes because they rely on content in the app. It helps to think about this before merging a PR, so this commit adds a reminder to the PR review checklist to think about it.
Things to consider when reviewing