update python style guide #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we just use `ruff format` now as it's pretty close to black in functionality, faster, and we're already using ruff for linting so it's one less dependency
we should be using pyproject.toml for our libraries
one less tool! one less tool! it's also much faster and more or less a drop in replacement
CrystalPea
approved these changes
Feb 20, 2025
katstevens
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff formatinstead ofblackwe just use
ruff formatas a drop-in replacement for black now, and we were already using ruff for linting so this feels like a no-brainerpyproject.tomlinstead ofsetup.pypyproject.toml is the accepted way to define metadata for libraries
uvinstead ofpip-toolsandpyenvuv does the job of those tools, but faster! this may be marginally more contentious than the alternatives as it's a bit of a shift and means there's another requirement you need just to get your project running but notify switched to uv last november and it definitely speeds up builds, especially locally