Merge pull request #3423 from alphagov/remove_ur_banner_21_10

Remove HMRC UR banner
alphagov · Nov 18, 2024 · 733644a · 733644a
2 parents 3cd7f33 + dea46aa
commit 733644a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 38 deletions.
diff --git a/lib/data/recruitment_banners.yml b/lib/data/recruitment_banners.yml
@@ -9,13 +9,6 @@
   #     - /foreign-travel-advice
 
 banners:
-- name: HMRC banner 21/10/2024
-  suggestion_text: "Help improve GOV.UK"
-  suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"
-  survey_url: https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_PAS_TAD
-  page_paths:
-    - /guidance/keeping-your-hmrc-login-details-safe
-    - /government/collections/hmrc-phishing-and-scams-detailed-information
 - name: AI banner 11/11/2024
   suggestion_text: "Help improve GOV.UK"
   suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"

diff --git a/test/integration/recruitment_banner_test.rb b/test/integration/recruitment_banner_test.rb
@@ -1,37 +1,6 @@
 require "test_helper"
 
 class RecruitmentBannerTest < ActionDispatch::IntegrationTest
-  test "HMRC banner 21/10/2024 is displayed on detailed guide of interest" do
-    detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
-
-    detailed_guide["base_path"] = "/guidance/keeping-your-hmrc-login-details-safe"
-    stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
-    visit detailed_guide["base_path"]
-
-    assert page.has_css?(".gem-c-intervention")
-    assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_PAS_TAD")
-  end
-
-  test "HMRC banner 21/10/2024 is displayed on document collection of interest" do
-    document_collection = GovukSchemas::Example.find("document_collection", example_name: "document_collection")
-
-    document_collection["base_path"] = "/government/collections/hmrc-phishing-and-scams-detailed-information"
-    stub_content_store_has_item(document_collection["base_path"], document_collection.to_json)
-    visit document_collection["base_path"]
-
-    assert page.has_css?(".gem-c-intervention")
-    assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_PAS_TAD")
-  end
-
-  test "HMRC banner 21/10/2024 is not displayed on all pages" do
-    detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
-    detailed_guide["base_path"] = "/nothing-to-see-here"
-    stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
-    visit detailed_guide["base_path"]
-
-    assert_not page.has_css?(".gem-c-intervention")
-  end
-
   test "AI banner 11/11/2024 is displayed on guides of interest" do
     guide_paths = [
       "/self-assessment-tax-returns",