Skip to content

Commit

Permalink
Merge pull request #3354 from alphagov/revert-3351-take_down_hmrc_banner
Browse files Browse the repository at this point in the history
Revert "Take down HMRC's UR banner"
  • Loading branch information
hannako authored Oct 7, 2024
2 parents eba40e6 + c0dbe6b commit f2a8b25
Show file tree
Hide file tree
Showing 5 changed files with 100 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/views/content_items/answer.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
<%= @requested_variant.analytics_meta_tag.html_safe if @requested_variant.present? %>
<% end %>
<%= render 'shared/intervention_banner' %>
<%= render 'content_items/body_with_related_links' %>
1 change: 1 addition & 0 deletions app/views/content_items/document_collection.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
schema: :article
) %>
<% end %>
<%= render 'shared/intervention_banner' %>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= render 'govuk_publishing_components/components/title',
Expand Down
2 changes: 2 additions & 0 deletions app/views/content_items/guide.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
<% content_for :simple_header, true %>
<%= render 'shared/intervention_banner' %>

<div class="govuk-grid-row gem-print-columns-none">
<div class="govuk-grid-column-two-thirds">
<%= render 'govuk_publishing_components/components/title', { title: @content_item.content_title } %>
Expand Down
16 changes: 15 additions & 1 deletion lib/data/recruitment_banners.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
banners:
# Example usage of adding a banner to the banners list:

# - name: Banner 1
Expand All @@ -9,3 +8,18 @@ banners:
# - /
# - /foreign-travel-advice

banners:
- name: HMRC banner 29/08/2024
suggestion_text: "Help improve GOV.UK"
suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"
survey_url: https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance
page_paths:
- /government/collections/tax-compliance-detailed-information
- /government/collections/hm-revenue-and-customs-compliance-checks-factsheets
- /difficulties-paying-hmrc
- /tax-help
- /get-help-hmrc-extra-support
- /guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support
- /tax-appeals
- /guidance/how-to-get-a-review-of-an-hmrc-decision
- /guidance/tax-disputes-alternative-dispute-resolution-adr
81 changes: 81 additions & 0 deletions test/integration/recruitment_banner_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
require "test_helper"

class RecruitmentBannerTest < ActionDispatch::IntegrationTest
def hmrc_banner_survey_url
"https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance"
end

test "HMRC banner 29/08/2024 is displayed on detailed guides of interest" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide_paths = [
"/guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support",
"/guidance/how-to-get-a-review-of-an-hmrc-decision",
"/guidance/tax-disputes-alternative-dispute-resolution-adr",
]

detailed_guide_paths.each do |path|
detailed_guide["base_path"] = path
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on document collections of interest" do
document_collection = GovukSchemas::Example.find("document_collection", example_name: "document_collection")
document_collection_paths = [
"/government/collections/tax-compliance-detailed-information",
"/government/collections/hm-revenue-and-customs-compliance-checks-factsheets",
]

document_collection_paths.each do |path|
document_collection["base_path"] = path
stub_content_store_has_item(document_collection["base_path"], document_collection.to_json)
visit document_collection["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on guides of interest" do
guide = GovukSchemas::Example.find("guide", example_name: "guide")
guide_paths = [
"/difficulties-paying-hmrc",
"/tax-help",
"/get-help-hmrc-extra-support",
"/tax-appeals",
]

guide_paths.each do |path|
guide["base_path"] = path
stub_content_store_has_item(guide["base_path"], guide.to_json)
visit guide["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on answer pages of interest" do
answer = GovukSchemas::Example.find("answer", example_name: "answer")

answer["base_path"] = "/tax-help"
stub_content_store_has_item(answer["base_path"], answer.to_json)
visit answer["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end

test "HMRC banner 29/08/2024 is not displayed on all pages" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide["base_path"] = "/nothing-to-see-here"
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert_not page.has_css?(".gem-c-intervention")
end
end

0 comments on commit f2a8b25

Please sign in to comment.