Turn digests back on in test environment #2767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://trello.com/c/fc41oyEK/1923-enable-individual-loading-of-stylesheets-in-government-frontend.
Turn digests back on (remove
config.assets.digest = false
) in test environment as a pre-requisite to implementing the AssetHelper to load component and view style sheets only required on the page being viewed.Why
The default
config.assets.digest
was changed here: a806be8 due to an issue loading Axe core in integration tests (with a comment to re-enable the option).I've discovered an issue running some tests when individual style sheets are loaded with the GOV.UK Publishing Components AssetHelper module.
_step-by-step-nav-related.css
. All other CSS files are loaded correctly_step-by-step-nav-related.css
seems to be incorrectly identified as having a digest as documented here: Some assets don't get delivered anymore after update to 4.1.1 because of funky name conflict (dashes make them look like digest for the Regexp) rails/sprockets#749-related
is stripped from the stylesheet path, which seems to cause an issue withstep-by-step-nav.css
._attachment-link.css
).With digests re-enabled I've seen no issues running component guide accessibility tests locally -
Notice
Banner
Visual changes
None.