Fix sass warnings

[andysellick]

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Fixes some Sass compilation warnings, that look like this:

13:28:45 css.1  |    ┌──> app/assets/stylesheets/helpers/_publisher-metadata-with-logo.scss
13:28:45 css.1  | 7  │     margin-left: govuk-spacing(3);
13:28:45 css.1  |    │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
13:28:45 css.1  |    ╵
13:28:45 css.1  |    ┌──> ../../../.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/govuk_publishing_components-43.0.2/node_modules/govuk-frontend/dist/govuk/helpers/_clearfix.scss
13:28:45 css.1  | 10 │ ┌   &::after {
13:28:45 css.1  | 11 │ │     content: "";
13:28:45 css.1  | 12 │ │     display: block;
13:28:45 css.1  | 13 │ │     clear: both;
13:28:45 css.1  | 14 │ │   }
13:28:45 css.1  |    │ └─── nested rule
13:28:45 css.1  |    ╵
13:28:45 css.1  |     app/assets/stylesheets/helpers/_publisher-metadata-with-logo.scss 7:3  @import
13:28:45 css.1  |     app/assets/stylesheets/application.scss 19:9                           root stylesheet

This involves moving all the @ declarations to after the other statements. I think all the changes here are fine, the only one I hesitated over was moving govuk-font after a text colour setting, when it was previously before - I don't think govuk-font sets a colour, but I can't find the right line in govuk-frontend to confirm that.

Why

There was a change to a dependency recently where this arrangement of selectors was suddenly required, so we're having to update quite a few Sass files to silence these warnings.

Visual changes

None.

[AshGDS]

LGTM 👍

I think the govuk-font docs you want are here: https://frontend.design-system.service.gov.uk/sass-api-reference/#govuk-font

Which references this file: https://github.com/alphagov/govuk-frontend/blob/v5.6.0/packages/govuk-frontend/src/govuk/helpers/_typography.scss#L270-L286