Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #3340

Closed
wants to merge 20 commits into from
Closed

WIP #3340

wants to merge 20 commits into from

Conversation

CodeSonia
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3340 September 20, 2024 09:16 Inactive
dependabot bot and others added 19 commits September 27, 2024 15:02
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/jasmine/jasmine/releases)
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: jasmine-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 43.1.0 to 43.1.1.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v43.1.0...v43.1.1)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
This commit removes some of the rules that were previously set for the
`.main-content-container` and instead uses the column rules from
`govuk-frontend`.

The container has now been renamed as `contents-container` to be
consistent with the `contents-list-container`. I had hoped to remove
this class entirely, but it's required to apply different float rules
when in RTL reading mode.

This also adds the new class for collapsing columns to full width
when printing.
Bumps [slimmer](https://github.com/alphagov/slimmer) from 18.6.1 to 18.6.2.
- [Changelog](https://github.com/alphagov/slimmer/blob/main/CHANGELOG.md)
- [Commits](alphagov/slimmer@v18.6.1...v18.6.2)

---
updated-dependencies:
- dependency-name: slimmer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 43.1.1 to 43.3.0.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v43.1.1...v43.3.0)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 9.14.0 to 9.14.1.
- [Changelog](https://github.com/alphagov/govuk_app_config/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_app_config@v9.14.0...v9.14.1)

---
updated-dependencies:
- dependency-name: govuk_app_config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 43.3.0 to 43.4.1.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v43.3.0...v43.4.1)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 43.4.1 to 43.5.0.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v43.4.1...v43.5.0)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 9.14.1 to 9.14.2.
- [Changelog](https://github.com/alphagov/govuk_app_config/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_app_config@v9.14.1...v9.14.2)

---
updated-dependencies:
- dependency-name: govuk_app_config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Amended the first_item_content method so that it accounts for nested div elements and processes their child elements, so that there is sufficient content to consider rendering a list.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3340 September 27, 2024 14:02 Inactive
@CodeSonia CodeSonia closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants