Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint-config-gds from 0.2.0 to 0.3.0 #2757

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2023

Bumps stylelint-config-gds from 0.2.0 to 0.3.0.

Changelog

Sourced from stylelint-config-gds's changelog.

0.3.0

This release updates all bundled configs to the maximum version supported by Stylelint 14. This work is in preparation for Stylelint 15 deprecating all stylistic rules with a recommendation to use Prettier for formatting.

Updates to bundled configs include new rule changes to maintain compatibility:

  • New rule selector-not-notation (added in stylelint@14.7.0) configured with simple :not() notation from CSS Selectors Level 3, maintaining support for older browsers
  • New rule annotation-no-unknown (added in stylelint@14.10.0) configured to maintain support for Sass flags such as !default and !global
Commits
  • ebae6ce Merge pull request #30 from colinrotherham/stylelint-14-15
  • fa2dd00 Bump version to 0.3.0
  • bafe5ea Configure stylelint@14.10.0 annotation-no-unknown
  • 452249c Configure stylelint@14.7.0 selector-not-notation
  • 64c77fa Update stylelint@14 compatible packages
  • 1cc74d7 Use package-lock.json "lockfileVersion": 2
  • 4922634 Use Node.js LTS ‘Hydrogen’ (v18)
  • 9e9842d Merge pull request #29 from alphagov/dependabot/npm_and_yarn/minimatch-3.1.2
  • cd81dff Bump minimatch from 3.0.4 to 3.1.2
  • 066bdb6 Merge pull request #28 from alphagov/dependabot/npm_and_yarn/json5-1.0.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/alphagov/stylelint-config-gds/releases)
- [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md)
- [Commits](alphagov/stylelint-config-gds@0.2.0...0.3.0)

---
updated-dependencies:
- dependency-name: stylelint-config-gds
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 1, 2023
@dependabot dependabot bot requested a review from a team May 1, 2023 09:57
@netlify
Copy link

netlify bot commented May 1, 2023

You can preview this change here:

Name Link
🔨 Latest commit 7fa3915
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/644f8d0c7959a00007a87f24
😎 Deploy Preview https://deploy-preview-2757--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update bumps the bundled Stylelint configs to their latest v14-supported versions

Everything still passing

@colinrotherham colinrotherham merged commit 17718c0 into main May 3, 2023
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/stylelint-config-gds-0.3.0 branch May 3, 2023 14:06
@domoscargin
Copy link
Contributor

Do we need to do anything active about the Prettier thing?

@colinrotherham
Copy link
Contributor

Do we need to do anything active about the Prettier thing?

@domoscargin Not just yet, but once this PR lands we'll suddenly lose stylistic rules:

At which point we'll flick Prettier on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants