Replace start using a service screenshots #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
selfthinker
changed the title
|
I think the screenshots work well as replacements. (It's interesting that the text first refers to "applying for probate" although it's not related to either of the original screenshots. I think it does make sense out of context without any of the images, it's just a bit weird.) |
owenatgov
force-pushed
the
update-start-using-a-service-screenshots
branch
from
bdc7064
to
f8f2995
Compare
|
I've tried to adjust the following sentence to still link to the blog but de-emphasise the mention of the Carer's Allowance guide. Probably one for @calvin-lau-sig7 to review when he has time. |
|
@calvin-lau-sig7 I like it! If I do some commit squashing are you happy to approve? |
This is in response to an issue raised by DAC that the screenshots we use are putting content after the start button which is an accessibility issue. See #4026
Tries to de-emphasise the Carer's Allowance service as the previous screenshot is no longer of that service, meaning the content doesn't flow quite as well Edit de-emphasis message after review from content designer
owenatgov
force-pushed
the
update-start-using-a-service-screenshots
branch
from
bc02965
to
49508aa
Compare
calvin-lau-sig7
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This is in response to an issue raised by DAC that the screenshots we use on the Start using a service pattern are putting content after the start button which is an accessibility issue.
Fixes #4026 (more details in issue)
Notes
There's a question on if we should also remove or amend the line just below the second screenshot which references the Carer's Allowance service since we're no longer using that service as a reference.