Update index.md to add a tool for Django #4430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an entry for Crispy Forms GDS, a template pack for Django Crispy Forms to generate forms and pages for the GOV.UK Frontend for Django based web sites.
✅ You can preview this change here:Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
owenatgov
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Hi @StuartMacKay. Sorry this has taken so long to respond to. Thanks for the contribution!
I'm happy with this in proncipal, however there are a couple of things I'd like to address regarding the the tool to ensure it meets requirements for our resource and tools contribution criteria:
- In the readme it lists 2.x (the latest version from tags being 2.0.1) as supporting govuk-frontend v5 to v5.8. I'm unclear on what this means. Is this clarified somewhere?
- The readme is out of date and suggets that the tool is still in development. Could this be updated please?
- Would you also be willing to add the quote at the bottom of the linked contribution criteria OR clearly indicate somewhere that this is a community resource and not an official part of the GOV.UK Design System?
I'm happy to raise these and 1 or more issues on the repo if that's easier. Once these are resolved I reckon this can get added no problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry for Crispy Forms GDS, a template pack for Django Crispy Forms to generate forms and pages for the GOV.UK Frontend for Django based web sites.