Workaround delays in ~/.npm cache restore time
#4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrades to v3 to avoid a bug in GitHub actions/cache actions/cache#810 Cache restore times for ~/.npm going over 5 minutes
colinrotherham
added
🐛 bug
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4558
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 900c112 |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4558
colinrotherham
changed the title
~/.npm cache restore time~/.npm cache restore time
romaricpascal
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Changes look good to solve the issue, with install running in a decent (for windows) time. 😄
It looks like we may be able to revert that PR at the next release of setup-node, though. I'll leave it with you to pick whether to merge then revert or hold for GitHub's next setup-node release (not sure of their lifecycle for that kind of things).
|
@romaricpascal Yeah spotted that today 🙌 After opening this PR I submitted feedback via a GitHub Actions survey and linked to a few issues Hopefully it all helped with the fix. I'll drop the Dependabot Update: I've confirmed the fix works via actions/setup-node#878 (comment) |
Now that Node.js 20 is available to local runners, we no longer need to agressively download the latest version on every run
colinrotherham
force-pushed
the
setup-node-delay
branch
from
4d7e1d0
to
900c112
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4558
owenatgov
pushed a commit
that referenced
this pull request
Jan 11, 2024
Workaround delays in `~/.npm` cache restore time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen 5+ minutes for Windows
~/.npmcache restore since #4494 was mergedThis PR rolls back to
actions/setup-node@v4.0.0actions/setup-node@v3.8.2to avoid it:Node.js
keepAlivedefaultThe issue is caused by Node.js and fixed in
actions/cachebut needs anactions/setup-nodebumpThere was a similar fix for
ruby/setup-rubyfor more information