Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import transition RDS instance #1286

Merged
merged 10 commits into from
May 9, 2024
Merged

Import transition RDS instance #1286

merged 10 commits into from
May 9, 2024

Conversation

samsimpson1
Copy link
Member

This will need to wait until next week, it will take a couple of hours to do the migration and it will result in a bit of downtime (changing subnet groups means having to move the instance out of the VPC and back in again, thanks AWS)

#1127

Copy link
Contributor

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@sengi
Copy link
Contributor

sengi commented May 3, 2024

Sorry for not updating those instance types btw. Good catch.

samsimpson1 and others added 6 commits May 9, 2024 10:18
By default Brakeman returns a non-zero exit code if any security warnings are found or scanning errors are encountered.
This ensures the scan output (SARIF file) gets uploaded to GitHub Code scanning.
@samsimpson1 samsimpson1 merged commit 53d5c19 into main May 9, 2024
4 checks passed
@samsimpson1 samsimpson1 deleted the samsimpson1/big-import branch May 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants