Manage aws-logging bucket #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from infra-monitoring in govuk-aws
| "id": "govuk-${var.govuk_environment}-gcp-logging" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
These import files are temporary, so formatting shouldn't really matter. They will be removed once importing has been done
theseanything
approved these changes
Jul 11, 2024
samsimpson1
force-pushed
the
samsimpson1/aws-import
branch
from
76aec36
to
1eea8d8
Compare
samsimpson1
force-pushed
the
samsimpson1/aws-import
branch
from
1eea8d8
to
1e08b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from infra-monitoring in govuk-aws.
Imports are in JSON format as they're generated by a script.
This also fixes terraform wanting to create the gcp-logging bucket in google cloud.
#1127