Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security scans to CI pipeline #31

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Add security scans to CI pipeline #31

merged 1 commit into from
Jul 12, 2024

Conversation

MuriloDalRi
Copy link
Contributor

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@MuriloDalRi MuriloDalRi marked this pull request as ready for review July 9, 2024 12:57
@sengi
Copy link
Contributor

sengi commented Jul 10, 2024

The commit title provides zero information about the change (because Git already knows which files are involved). If we allow generic commit titles like this, the usefulness of the commit history degrades over time. Could you please change it to, say, "Add security scans" like you've written in the description?

Same for the other PRs.

@MuriloDalRi MuriloDalRi changed the title Update ci.yml Add security scans to CI pipeline Jul 10, 2024
Copy link
Contributor

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MuriloDalRi MuriloDalRi merged commit 54b2be0 into main Jul 12, 2024
6 checks passed
@MuriloDalRi MuriloDalRi deleted the add-security-scans branch July 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants