Merge pull request #2370 from alphagov/support-no-internet-connection

Support no internet connection
alphagov · Nov 9, 2023 · 3a36712 · 3a36712
2 parents 9afd727 + ff10068
commit 3a36712
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- [#2370: Support no internet connection](https://github.com/alphagov/govuk-prototype-kit/pull/2370)
+
 ## 13.14.0
 
 ### New features

diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -268,9 +268,13 @@ function sortByObjectKey (key) {
 }
 
 function hasNewVersion (installedVersion, latestVersion) {
+  if (!latestVersion) {
+    return false
+  }
+
   const matcher = /^(\d+)\.(\d+)\.(\d+)(.+)?/
-  const [, installedMajor, installedMinor, installedPatch, installedSuffix] = installedVersion.match(matcher)
-  const [, latestMajor, latestMinor, latestPatch, latestSuffix] = latestVersion.match(matcher)
+  const [, installedMajor, installedMinor, installedPatch, installedSuffix] = installedVersion?.match(matcher) || []
+  const [, latestMajor, latestMinor, latestPatch, latestSuffix] = latestVersion?.match(matcher) || []
 
   if (installedMajor < latestMajor) return true
   if (installedMajor > latestMajor) return false

diff --git a/lib/utils/utils.test.js b/lib/utils/utils.test.js
@@ -29,6 +29,7 @@ describe('sessionFileStoreQuietLogFn', () => {
 
 describe('hasNewVersion', () => {
   [
+    { installed: '13.1.0', latest: undefined, result: false },
     { installed: '13.1.0', latest: '13.1.0', result: false },
     { installed: '13.1.1', latest: '13.1.0', result: false },
     { installed: '13.2.0', latest: '13.1.0', result: false },